Hello Rob,
Thank you for the review.
On Wed, 7 Mar 2018 16:30:48 -0600
Rob Herring <robh@xxxxxxxxxx> wrote:
> On Mon, Mar 05, 2018 at 01:48:17PM +0100, Mylène Josserand wrote:
> > Add a device-tree binding for Texas Instrument's PCM1789 codec.
> > For the moment, only I2C bus is supported but SPI could be added
> > in future.
> >
> > Signed-off-by: Mylène Josserand <mylene.josserand@xxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/sound/pcm1789.txt | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/pcm1789.txt
> >
> > diff --git a/Documentation/devicetree/bindings/sound/pcm1789.txt b/Documentation/devicetree/bindings/sound/pcm1789.txt
> > new file mode 100644
> > index 000000000000..a6cdc2c83c98
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/pcm1789.txt
> > @@ -0,0 +1,21 @@
> > +Texas Instruments pcm1789 DT bindings
>
> What function does this device provide?
Sorry, I forgot to mention this information.
>
> > +
> > +This driver supports the I2C bus.
>
> Bindings describe h/w, not drivers.
True, I will reformulate it.
>
> > +
> > +Required properties:
> > +
> > + - compatible: "ti,pcm1789"
> > +
> > +Required properties on I2C:
> > +
> > + - reg: the I2C address
> > + - reset-gpios: GPIO to control the RESET pin
> > +
> > +Examples:
> > +
> > + codec: pcm1789@4c {
>
> audio-codec@4c
>
> If that's the function...
Yep, I will change that.
>
> > + compatible = "ti,pcm1789";
> > + reg = <0x4c>;
> > + reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
> > + #sound-dai-cells = <0>;
> > + };
> > --
> > 2.11.0
> >
Thanks,
Best regards,
--
Mylène Josserand, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
