> -----Original Message----- > From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx] > Sent: Monday, February 26, 2018 3:10 PM > To: A.s. Dong <aisheng.dong@xxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; > Baruch Siach <baruch@xxxxxxxxxx>; Catalin Marinas > <catalin.marinas@xxxxxxx>; Will Deacon <will.deacon@xxxxxxx>; > patchwork-lst@xxxxxxxxxxxxxx; Rob Herring <robh+dt@xxxxxxxxxx>; dl- > linux-imx <linux-imx@xxxxxxx>; kernel@xxxxxxxxxxxxxx; Fabio Estevam > <fabio.estevam@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Lucas > Stach <l.stach@xxxxxxxxxxxxxx> > Subject: Re: [PATCH v2 2/4] arm64: add basic DTS for i.MX8MQ > > On Mon, Feb 26, 2018 at 06:52:15AM +0000, A.s. Dong wrote: > > Hi Shawn, > > > > > -----Original Message----- > > > From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx] > > > Sent: Monday, February 26, 2018 11:17 AM > > > To: A.s. Dong <aisheng.dong@xxxxxxx> > > > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>; Mark Rutland > > > <mark.rutland@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; Baruch Siach > > > <baruch@xxxxxxxxxx>; Catalin Marinas <catalin.marinas@xxxxxxx>; Will > > > Deacon <will.deacon@xxxxxxx>; patchwork-lst@xxxxxxxxxxxxxx; Rob > > > Herring <robh+dt@xxxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > > > kernel@xxxxxxxxxxxxxx; Fabio Estevam <fabio.estevam@xxxxxxx>; > linux- > > > arm-kernel@xxxxxxxxxxxxxxxxxxx > > > Subject: Re: [PATCH v2 2/4] arm64: add basic DTS for i.MX8MQ > > > > > > On Sun, Feb 25, 2018 at 10:47:11AM +0000, A.s. Dong wrote: > > > > > Documentation/devicetree/bindings/arm/fsl.txt | 4 + > > > > > arch/arm64/boot/dts/freescale/imx8mq-pinfunc.h | 623 > > > > > +++++++++++++++++++++++++ > > > > > > > > Should this belongs to pinctrl part? > > > > > > No. Those pinfunc defines are used by device tree rather than pinctrl > driver. > > > > > > > I had this question because we have below info in the patch > > "dt-bindings: add binding for i.MX8MQ IOMUXC": > > > > diff --git > > a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt > > b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt > > new file mode 100644 > > index 0000000..5c5d2d8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt > > @@ -0,0 +1,39 @@ > > ... > > + Refer to imx8mq-pinfunc.h in device tree source folder for all available > > + imx8mq PIN_FUNC_ID. > > This is just a cross reference in document, and should be okay on different > tree during development cycle. If we have the pinfunc header go via pinctrl > tree, we will have a more serious dependency between DT and pinctrl tree. > Okay, understand now. Regards Dong Aisheng > Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html