On 02/22/2018 02:47 PM, Linus Walleij wrote: > On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay <amelie.delaunay@xxxxxx> wrote: > >> ST Multi-Function eXpander (MFX) can be used as GPIO expander. >> It has 16 fast GPIOs and can have 8 extra alternate GPIOs >> when other MFX features are not enabled. >> >> Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxx> > > As mentioned I think this driver needs to: > > - Move to drivers/pinctrl/pinctrl-stmfx.c similar to the sx150x controller. > - Pass a regmap around instead of the custom accessor functions. I study this right now! Thanks, Amelie > - Maybe refactor and reuse STMPE infrastructure > > Yours, > Linus Walleij > ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f