On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay <amelie.delaunay@xxxxxx> wrote: > ST Multi-Function eXpander (MFX) can be used as GPIO expander. > It has 16 fast GPIOs and can have 8 extra alternate GPIOs > when other MFX features are not enabled. > > Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxx> As mentioned I think this driver needs to: - Move to drivers/pinctrl/pinctrl-stmfx.c similar to the sx150x controller. - Pass a regmap around instead of the custom accessor functions. - Maybe refactor and reuse STMPE infrastructure Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html