Re: [PATCH] dt-bindings: memory: ti-emif: add edac support under emif

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 19, 2018 at 12:21 AM, Tero Kristo <t-kristo@xxxxxx> wrote:
> On 19/02/18 05:10, Rob Herring wrote:
>>
>> On Tue, Feb 13, 2018 at 07:15:29PM +0200, Tero Kristo wrote:
>>>
>>> Certain revisions of the TI EMIF IP contain ECC support in them. Reflect
>>> this in the DT binding. Also, add interrupts property as a required
>>> property for the emif controller, as all revisions of the emif IP contain
>>> interrupt support; this might remain unused by the kernel driver though.
>>>
>>> Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
>>> ---
>>>   .../devicetree/bindings/memory-controllers/ti/emif.txt      | 13
>>> ++++++++++++-
>>>   1 file changed, 12 insertions(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/memory-controllers/ti/emif.txt
>>> b/Documentation/devicetree/bindings/memory-controllers/ti/emif.txt
>>> index 621b41c..87022a9 100644
>>> --- a/Documentation/devicetree/bindings/memory-controllers/ti/emif.txt
>>> +++ b/Documentation/devicetree/bindings/memory-controllers/ti/emif.txt
>>> @@ -3,7 +3,9 @@
>>>   EMIF - External Memory Interface - is an SDRAM controller used in
>>>   TI SoCs. EMIF supports, based on the IP revision, one or more of
>>>   DDR2/DDR3/LPDDR2 protocols. This binding describes a given instance
>>> -of the EMIF IP and memory parts attached to it.
>>> +of the EMIF IP and memory parts attached to it. Certain revisions
>>> +of the EMIF controller also contain optional ECC support, which
>>> +corrects one bit errors and detects two bit errors.
>>>     Required properties:
>>>   - compatible  : Should be of the form "ti,emif-<ip-rev>" where <ip-rev>
>>> @@ -11,6 +13,8 @@ Required properties:
>>>     compatible should be one of the following:
>>>              "ti,emif-am3352"
>>>              "ti,emif-am4372"
>>> +            "ti,emif-dra7xx"
>>> +            "ti,emif-keystone"
>>>     - phy-type  : <u32> indicating the DDR phy type. Following are the
>>>     allowed values
>>> @@ -22,6 +26,7 @@ Required properties:
>>>   - ti,hwmods   : For TI hwmods processing and omap device creation
>>>     the value shall be "emif<n>" where <n> is the number of the EMIF
>>>     instance with base 1.
>>> +- interrupts   : interrupt used by the controller
>>
>>
>> Only for the new compatibles?
>
>
> I added this as required property for all, as all EMIF versions actually do
> have IRQ. Should this still be marked as optional as only certain versions
> of the driver use it? On am3/am4 only it is optional right now, and not used
> by the existing driver. On omap4 and omap5 it is required also (list of
> compatibles for the binding seem to be missing these actually; ti,emif-4d
> and ti,emif-4d5.)
>
> Either way, I can mark this as optional property for am3/am4 if you want (I
> actually asked this already before but did not get clear response), what is
> your final take on this?

Okay. I'm fine if it is required. You're going to update all the dts
files, right?

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux