On Tue, Feb 13, 2018 at 07:15:29PM +0200, Tero Kristo wrote: > Certain revisions of the TI EMIF IP contain ECC support in them. Reflect > this in the DT binding. Also, add interrupts property as a required > property for the emif controller, as all revisions of the emif IP contain > interrupt support; this might remain unused by the kernel driver though. > > Signed-off-by: Tero Kristo <t-kristo@xxxxxx> > --- > .../devicetree/bindings/memory-controllers/ti/emif.txt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/ti/emif.txt b/Documentation/devicetree/bindings/memory-controllers/ti/emif.txt > index 621b41c..87022a9 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/ti/emif.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/ti/emif.txt > @@ -3,7 +3,9 @@ > EMIF - External Memory Interface - is an SDRAM controller used in > TI SoCs. EMIF supports, based on the IP revision, one or more of > DDR2/DDR3/LPDDR2 protocols. This binding describes a given instance > -of the EMIF IP and memory parts attached to it. > +of the EMIF IP and memory parts attached to it. Certain revisions > +of the EMIF controller also contain optional ECC support, which > +corrects one bit errors and detects two bit errors. > > Required properties: > - compatible : Should be of the form "ti,emif-<ip-rev>" where <ip-rev> > @@ -11,6 +13,8 @@ Required properties: > compatible should be one of the following: > "ti,emif-am3352" > "ti,emif-am4372" > + "ti,emif-dra7xx" > + "ti,emif-keystone" > > - phy-type : <u32> indicating the DDR phy type. Following are the > allowed values > @@ -22,6 +26,7 @@ Required properties: > - ti,hwmods : For TI hwmods processing and omap device creation > the value shall be "emif<n>" where <n> is the number of the EMIF > instance with base 1. > +- interrupts : interrupt used by the controller Only for the new compatibles? > > Required only for "ti,emif-am3352" and "ti,emif-am4372": > - sram : Phandles for generic sram driver nodes, > @@ -71,3 +76,9 @@ emif: emif@4c000000 { > sram = <&pm_sram_code > &pm_sram_data>; > }; > + > +emif1: emif@4c000000 { > + compatible = "ti,emif-dra7xx"; > + reg = <0x4c000000 0x200>; > + interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>; > +}; > -- > 1.9.1 > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html