Hi Laurent, On Thu, Feb 15, 2018 at 12:03 PM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > On Thursday, 15 February 2018 11:18:25 EET Geert Uytterhoeven wrote: >> On Thu, Feb 15, 2018 at 1:04 AM, Laurent Pinchart wrote: >> > The internal LVDS encoders now have their own DT bindings. Before >> > switching the driver infrastructure to those new bindings, implement >> > backward-compatibility through live DT patching. >> > >> > Patching is disabled and will be enabled along with support for the new >> > DT bindings in the DU driver. >> > >> > Signed-off-by: Laurent Pinchart >> > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> >> >> Thanks for your patch! >> >> > --- /dev/null >> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dts >> > @@ -0,0 +1,81 @@ >> > +// SPDX-License-Identifier: GPL-2.0 >> > +/* >> > + * rcar_du_of_lvds_r8a7790.dts - Legacy LVDS DT bindings conversion for >> > R8A7790 + * >> > + * Copyright (C) 2018 Laurent Pinchart >> > <laurent.pinchart@xxxxxxxxxxxxxxxx> >> > + * >> > + * Based on work from Jyri Sarha <jsarha@xxxxxx> >> > + * Copyright (C) 2015 Texas Instruments >> > + */ >> > + >> > +#include <dt-bindings/clock/renesas-cpg-mssr.h> >> > + >> > +/dts-v1/; >> > +/plugin/; >> > +/ { >> > + fragment@1 { >> > + target-path = "/display@feb00000/ports"; >> >> Does this work now there can be an "soc" subnode, too? >> >> Your code obtains the right parent: >> >> soc_node = of_get_parent(du_node); >> >> but the overlay is applied without considering that, if I'm not mistaken. > > Correct, and as I can't modify the target-path in the overlay dynamically > anymore, I can't take this into account. I could duplicate the r8a7790 and > r8a7791 overlays in two versions to handle this, but as the soc subnode isn't > in mainline yet, I'd rather get this patch series merged with the current > implementation in v4.17 to not have to handle this issue :-) That's of course an option. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html