Hi Jacopo, On Wed, Feb 14, 2018 at 2:53 PM, jacopo mondi <jacopo@xxxxxxxxxx> wrote: > On Wed, Feb 14, 2018 at 02:37:08PM +0100, Geert Uytterhoeven wrote: >> On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi >> <jacopo+renesas@xxxxxxxxxx> wrote: >> > Add initial PFC support for R-Car M3-N (r8a77965) SoC. >> > No groups or functions defined, just pin and registers enumeration. >> > >> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> >> >> Thanks for your patch! >> >> Looks mostly OK to me. >> You do want to compare with pfc-r8a7796.c: all differences not related to >> SATA_DEVSL, FSCLK, DU_DOTCLKIN2/3, and PRESET are issues that were fixed >> recently in pfc-r8a7796.c, and should apply to pfc-r8a77965.c, too. >> > > I have used the M3-W tables with the exception of the pins/groups you > mentioned, that are clearly marked as different in the datasheet. At > least, this was my intention :) > > I used v4.15 M3-W PFC tables, should I look in v4.16-rc1 or in > renesas-drivers for updates? Always look at the latest version in my sh-pfc branch ;-) >> That leaves us with very few differences only, but it won't be trivial to have >> a combined M3-W/N PFC driver, I'm afraid. > > Takes a certain degree of grep-foo to clearly highlight differences > between the two version. Do you have any script/tools you use to > compare PFC tables a bit more easily? The "--no-index" option of git diff allows to compare files against each other, instead of against some other version. Can be combined with wdiff: $ git help wdiff `git wdiff' is aliased to `diff --color-words' soc-dts-diff (https://www.spinics.net/lists/linux-renesas-soc/msg22630.html) also helps, even for drivers. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
