Hi Jacopo, On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote: > Add initial PFC support for R-Car M3-N (r8a77965) SoC. > No groups or functions defined, just pin and registers enumeration. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> Thanks for your patch! Looks mostly OK to me. You do want to compare with pfc-r8a7796.c: all differences not related to SATA_DEVSL, FSCLK, DU_DOTCLKIN2/3, and PRESET are issues that were fixed recently in pfc-r8a7796.c, and should apply to pfc-r8a77965.c, too. That leaves us with very few differences only, but it won't be trivial to have a combined M3-W/N PFC driver, I'm afraid. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html