On 02/12/2018 07:11 PM, Kieran Bingham wrote: [...] > + /* > + * The adv75xx resets its addresses to defaults during low power power > + * mode. Because we have two ADV7513 devices on the same bus, we must > + * change both of them away from the defaults so that they do not > + * conflict. > + */ > hdmi@3d { > compatible = "adi,adv7513"; > - reg = <0x3d>; > + reg = <0x3d 0x2d 0x4d, 0x5d>; To have the correct semantics this should be: reg = <0x3d>, <0x2d>, <0x4d>, <0x5d>; It is a set of 4 single cell addresses. The other thing is a single 4 cell address. It will get compiled to the same bytes, but the DT tools should complain about it, because it doesn't match #address-cells. > + reg-names = "main", "cec", "edid", "packet"; > > adi,input-depth = <8>; > adi,input-colorspace = "rgb"; > @@ -272,7 +279,8 @@ > > hdmi@39 { > compatible = "adi,adv7513"; > - reg = <0x39>; > + reg = <0x39 0x29 0x49, 0x59>; Same here. > + reg-names = "main", "cec", "edid", "packet"; > > adi,input-depth = <8>; > adi,input-colorspace = "rgb"; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html