On Thursday 08 February 2018 03:24 PM, Bartosz Golaszewski wrote: > 2018-02-08 10:30 GMT+01:00 Sekhar Nori <nsekhar@xxxxxx>: >> On Wednesday 07 February 2018 07:15 PM, Bartosz Golaszewski wrote: >>> + /* >>> + * DaVinci always uses a single clock for power-management. We assume >>> + * it's the first one in the clocks property. >>> + */ >>> + clk = of_clk_get(dev->of_node, 0); >>> + if (IS_ERR(clk)) >>> + return PTR_ERR(clk); >> >> We already get this today with drivers/base/power/clock_ops.c once >> .con_ids list is dropped from pm_clk_notifier_block (which I think it >> should). >> >> If there is no reason to introduce thus functionality at this stage, >> perhaps we should wait till such a time when its clearly needed? >> >> Thanks, >> Sekhar > > If I understand correctly: once we drop the con_ids list, we end up > calling clk_get(dev, NULL) from pm_clk_acquire(), which matches > against the clock with NULL con_id, which may not necessarily be the > first clock in the list. Hmm, not sure of this. In __of_clk_get_by_name() called by clk_get(): int index = 0; /* * For named clocks, first look up the name in the * "clock-names" property. If it cannot be found, then * index will be an error code, and of_clk_get() will fail. */ if (name) index = of_property_match_string(np, "clock-names", name); So, if no con_id is provided (name == NULL), then index is set to 0 which will always get the first clock in clocks = list. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
