2018-02-08 10:30 GMT+01:00 Sekhar Nori <nsekhar@xxxxxx>: > On Wednesday 07 February 2018 07:15 PM, Bartosz Golaszewski wrote: >> + /* >> + * DaVinci always uses a single clock for power-management. We assume >> + * it's the first one in the clocks property. >> + */ >> + clk = of_clk_get(dev->of_node, 0); >> + if (IS_ERR(clk)) >> + return PTR_ERR(clk); > > We already get this today with drivers/base/power/clock_ops.c once > .con_ids list is dropped from pm_clk_notifier_block (which I think it > should). > > If there is no reason to introduce thus functionality at this stage, > perhaps we should wait till such a time when its clearly needed? > > Thanks, > Sekhar If I understand correctly: once we drop the con_ids list, we end up calling clk_get(dev, NULL) from pm_clk_acquire(), which matches against the clock with NULL con_id, which may not necessarily be the first clock in the list. I'm working on extending the psc driver with the power-domain code (as suggested by David), which should be much smaller and simplier - how about that? Thanks, Bartosz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
