On Fri, Jan 17, 2014 at 09:13:40AM -0300, Ezequiel Garcia wrote: > Some flashes can only be properly accessed when the ECC mode is > specified, and a way to describe such mode is required. > > Such ECC mode is completely driver-specific so instead of having one binding > per compatible-string, let's add generic ECC strength and ECC step size. > Driver's can choose the appropriate ECC mode, based on this specification. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/mtd/nand.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documentation/devicetree/bindings/mtd/nand.txt > index 03855c8..683a310 100644 > --- a/Documentation/devicetree/bindings/mtd/nand.txt > +++ b/Documentation/devicetree/bindings/mtd/nand.txt > @@ -3,5 +3,9 @@ > - nand-ecc-mode : String, operation mode of the NAND ecc mode. > Supported values are: "none", "soft", "hw", "hw_syndrome", "hw_oob_first", > "soft_bch". > +- nand-ecc-strength : integer ECC required strength. > +- nand-ecc-size : integer step size associated to the ECC strength. > + The exact meaning of the ECC strength and ECC size parameters is completely > + driver-specific. > - nand-bus-width : 8 or 16 bus width if not present 8 > - nand-on-flash-bbt: boolean to enable on flash bbt option if not present false > -- > 1.8.1.5 > Brian, do you agree (as MTD maintainer) with this new binding? Can we get any Acks from a devicetree binding maintainer? Grant has already given his (informal) approval [1], but I'd rather have a formal ack from binding maintainer. Once this binding gets accepted, I'll submit an of_helper patch, and a patch for pxa3xx-nand to use it. [1] http://www.spinics.net/lists/devicetree/msg20534.html -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html