On Wed, Jan 24, 2018 at 1:56 AM, Vincent Chen <deanbo422@xxxxxxxxx> wrote: > 2018-01-18 18:30 GMT+08:00 Arnd Bergmann <arnd@xxxxxxxx>: >> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu <green.hu@xxxxxxxxx> wrote: >>> From: Greentime Hu <greentime@xxxxxxxxxxxxx> >>> >>> This patch adds support for signal handling. >>> >>> Signed-off-by: Vincent Chen <vincentc@xxxxxxxxxxxxx> >>> Signed-off-by: Greentime Hu <greentime@xxxxxxxxxxxxx> >> >> I never feel qualified enough to properly review signal handling code, so >> no Ack from me for this code even though I don't see anything wrong with it. >> Hopefully someone else can give an Ack after looking more closely. >> > > Dear Arnd: > > We'd be glad to improve signal handling code to meet your requirement. > Could you > tell us which part we need to refine or which implementation is good > for us to refer? No, as I said, the problem is on my side, I just don't understand enough of it. I would assume that the arm64 and risc-v implementations are the most thoroughly reviewed, but haven't looked at those in enough detail either. If your code does something that risc-v doesn't do, try to understand whether there should be a difference or not. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html