On Tue, 9 Jan 2018 11:36:30 +0100 Miquel Raynal <miquel.raynal@xxxxxxxxxxxxxxxxxx> wrote: > Hi, > > After the addition of the NAND framework ->exec_op() interface (see [1] > for the series preparing it and [2] for the last version of the > core-side implementation of ->exec_op() itself), this series replaces > the current Marvell NAND controller driver pxa3xx_nand.c with a rework > called marvell_nand.c. > > Aside the fact that it drops the big state machine, improves the overall > speed and implements raw accesses, it is the first driver-side > implementation of the ->exec_op() interface and may be used as reference > for latter reworks of the same type. > > One may find more detail about why a completely new driver is needed in > the commit log of: > > "mtd: nand: add reworked Marvell NAND controller driver" > > Device tree NAND node definition for all platforms referring to the > Marvell driver using the new bindings have already been accepted by the > MVEBU DT maintainers and will be merged after the driver. They are more > hierarchical and fit the real organization of the hardware, by having > NAND partitions that are part of NAND chip nodes, themselves part of the > NAND controller node. > > These changes have been tested on: > - PXA3xx platform with a CM-X300 board (2kiB page NAND, 1b/512B > strength, Hamming ECC engine) [32 bits] > - Armada 385 DB AP (4kiB page NAND, 4b/512B, BCH ECC engine) [32 bits] > - Armada 398 DB (4kiB page NAND, 8b/512B, BCH ECC engine using a layout > with a last chunk different than the others) [32 bits] > - Armada 7040 DB and Armada 8040 DB (4kiB page NAND, 4b/512B, BCH ECC > engine) [64 bits] > - Triax dvb-tc board (2kiB page NAND, 4b/512B, BCH ECC engine) [32 bits] > > This version is known not to be stable yet with a Zylonite based setup but > otherwise looks good for Marvell EBU platforms. > > For people who would like to test it easily, a branch ready to be tested > is available at [3]. It is based on nand/next and has all the changes > brought by the previously mentionned series as well as this one. > > Thank you, > Miquèl > > > [1] https://www.spinics.net/lists/arm-kernel/msg619633.html > [2] http://lists.infradead.org/pipermail/linux-mtd/2017-December/077965.html > [3] https://github.com/miquelraynal/linux/tree/marvell/nand-next/nfc > > > Changes since v2: > - Added a patch to create the nand-rb property in the Documentation > - Rewording in the Documentation according to Rob's comments > - Moved from marvell,rb to nand-rb property in the code > - Disociated using this driver with Marvell EBU platforms than using > it with PXA ones > - Fixed the handling of 16-bit buses > - Fixed SPDX comment style > - Reorganized registers offsets/bit fields definitions as requested > - Moved to Kernel doc > - Changed the logic in ->select_chip() to use a prepared value of NDCR > only instead of recalculating it > - Fixed the presence of the SPARE_EN bit, reworked a bit the > hmg_do_read/write() helpers > - Fixed the OOB layouts that were unusable (all spare data first, then > all ECC bytes) > - Additional check on mtd->writesize when using NFCv1 (all sizes not > supported) > - Various typos/rewording > > Changes since v1: > - Rewording > - Fixed BCH ->read/write_page() hooks for 2kiB pages NAND chips > - Removed license text, used SPDX tag instead > - Removed read_page_data() > - Enhanced the DT bindings document with the label property and the > deprecated bindings. > - Simplified the read_chunk() helper (OOB always read). > - Simplified the ->bch_read_page() hook by removing the addition raw > read to get ECC bytes. > - Fixed the ->correct() function that did not check for bitflips in > ECC bytes in erased pages. > > > Miquel Raynal (7): > dt-bindings: mtd: document new nand-rb property > dt-bindings: mtd: add Marvell NAND controller documentation > mtd: nand: add reworked Marvell NAND controller driver > mtd: nand: use reworked NAND controller driver with Marvell EBU SoCs Applied patches 1 to 4. Can you please send a patch to add a new entry in MAINTAINERS for this driver? Thanks, Boris > mtd: nand: use Marvell reworked NAND controller driver with all > platforms > dt-bindings: mtd: remove pxa3xx NAND controller documentation > mtd: nand: remove useless fields from pxa3xx NAND platform data > > .../devicetree/bindings/mtd/marvell-nand.txt | 123 + > Documentation/devicetree/bindings/mtd/nand.txt | 1 + > .../devicetree/bindings/mtd/pxa3xx-nand.txt | 50 - > arch/arm/configs/cm_x300_defconfig | 2 +- > arch/arm/configs/mvebu_v7_defconfig | 2 +- > arch/arm/configs/pxa3xx_defconfig | 3 +- > arch/arm/configs/pxa_defconfig | 2 +- > arch/arm/configs/raumfeld_defconfig | 2 +- > arch/arm/mach-mmp/ttc_dkb.c | 4 +- > arch/arm/mach-pxa/cm-x300.c | 8 +- > arch/arm/mach-pxa/colibri-pxa3xx.c | 8 +- > arch/arm/mach-pxa/colibri.h | 2 +- > arch/arm/mach-pxa/littleton.c | 10 +- > arch/arm/mach-pxa/mxm8x10.c | 10 +- > arch/arm/mach-pxa/raumfeld.c | 6 +- > arch/arm/mach-pxa/zylonite.c | 10 +- > arch/arm64/configs/defconfig | 2 +- > drivers/mtd/nand/Kconfig | 18 +- > drivers/mtd/nand/Makefile | 2 +- > drivers/mtd/nand/marvell_nand.c | 2896 ++++++++++++++++++++ > drivers/mtd/nand/pxa3xx_nand.c | 2104 -------------- > include/linux/platform_data/mtd-nand-pxa3xx.h | 43 +- > 22 files changed, 3072 insertions(+), 2236 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mtd/marvell-nand.txt > delete mode 100644 Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt > create mode 100644 drivers/mtd/nand/marvell_nand.c > delete mode 100644 drivers/mtd/nand/pxa3xx_nand.c > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
