On Friday, January 05, 2018, Sergei Shtylyov wrote:
> > + usbhs0: usbhs@e8010000 {
>
> The node names should be generic, i.e "usb@e8010000".
>
> > + compatible = "renesas,usbhs-r7s72100";
> > + reg = <0xe8010000 0x1A0>;
>
> Lowercase in the hex values, please be consistent...
>
> > + interrupts = <GIC_SPI (73-32) IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&mstp7_clks R7S72100_CLK_USB0>;
> > + renesas,buswait = <4>;
> > + power-domains = <&cpg_clocks>;
> > + status = "disabled";
> > + };
> > +
> > + usbhs1: usbhs@e8207000 {
> > + compatible = "renesas,usbhs-r7s72100";
> > + reg = <0xe8207000 0x1A0>;
> > + interrupts = <GIC_SPI (74-32) IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&mstp7_clks R7S72100_CLK_USB1>;
> > + renesas,buswait = <4>;
> > + power-domains = <&cpg_clocks>;
> > + status = "disabled";
> > + };
> > };
>
> The same comments for the 2nd device.
Thank you for the review.
I'll make the changes and resubmit.
Chris
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
