Thanks Simon for this information. Next time I will make sure that compiler won't give any warning message with make dtbs W=1 Regards, Biju > -----Original Message----- > From: Simon Horman [mailto:horms@xxxxxxxxxxxx] > Sent: 20 December 2017 09:58 > To: Biju Das <biju.das@xxxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland > <mark.rutland@xxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; Magnus > Damm <magnus.damm@xxxxxxxxx>; Chris Paterson > <Chris.Paterson2@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-renesas- > soc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 5/5] ARM: dts: iwg20d-q7-common: Enable SGTL5000 > audio codec > > On Tue, Dec 12, 2017 at 06:25:11PM +0000, Biju Das wrote: > > This patch enables SGTL5000 audio codec on the carrier board. > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > > Somehow I missed applying this one. > I have now done so with the minor update noted below. > > > --- > > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 24 > ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > index 54470c6..2070b14 100644 > > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > @@ -20,6 +20,20 @@ > > stdout-path = "serial0:115200n8"; > > }; > > > > +audio_clock: audio_clock { > > +compatible = "fixed-clock"; > > +#clock-cells = <0>; > > +clock-frequency = <26000000>; > > +}; > > + > > +reg_1p5v: 1p5v { > > +compatible = "regulator-fixed"; > > +regulator-name = "1P5V"; > > +regulator-min-microvolt = <1500000>; > > +regulator-max-microvolt = <1500000>; > > +regulator-always-on; > > +}; > > + > > vcc_sdhi1: regulator-vcc-sdhi1 { > > compatible = "regulator-fixed"; > > > > @@ -83,6 +97,16 @@ > > compatible = "ti,bq32000"; > > reg = <0x68>; > > }; > > + > > +sgtl5000: codec@0a { > > s/@0a/@a/ > > Base addresses should not have a leading 0. > > # make dtbs W=1 > DTC arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dtb > arch/arm/boot/dts/r8a7743-iwg20d-q7.dtb: Warning (unit_address_format): > Node /soc/i2c@e6530000/codec@0a unit name should not have leading 0s > > > +compatible = "fsl,sgtl5000"; > > +#sound-dai-cells = <0>; > > +reg = <0x0a>; > > +clocks = <&audio_clock>; > > +VDDA-supply = <®_3p3v>; > > +VDDIO-supply = <®_3p3v>; > > +VDDD-supply = <®_1p5v>; > > +}; > > }; > > > > &pci0 { > > -- > > 1.9.1 > > [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
