Re: [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Dec 13, 2017 at 11:57 AM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> This patch instantiates the thermal sensor module with thermal-zone
> support.
>
> This patch is based on the commit cac68a56e34b
> ("ARM: dts: r8a7791: enable to use thermal-zone") by Kuninori Morimoto.
>
> Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Minor nit below...

> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -250,6 +250,38 @@
>                         resets = <&cpg 407>;
>                 };
>
> +               thermal: thermal@e61f0000 {
> +                       compatible = "renesas,thermal-r8a7743",
> +                                    "renesas,rcar-gen2-thermal",
> +                                    "renesas,rcar-thermal";
> +                       reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;

<0 0xe61f0000 0 0x10>?

The register at offset 0x10 seems to exist on R-Mobile APE6 only, but
all R-Car Gen2 .dtsis include it in the range...

Not that it matters much, mapping granularity is PAGE_SIZE anyway...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux