Re: [PATCH v14 0/5] ZII RAVE platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, 19 Dec 2017, Johan Hovold wrote:

> On Tue, Dec 19, 2017 at 08:56:03AM +0000, Lee Jones wrote:
> > On Sat, 16 Dec 2017, Guenter Roeck wrote:
> > > On 12/07/2017 08:27 AM, Andrey Smirnov wrote:
> > > > Lee:
> > > > 
> > > > This patch set has been marinating out there for a while now and
> > > > yours, I belive, is that last signature I need to start pushing it for
> > > > inclusion. I'd really appreciate if you could spare some of your time
> > > > to give it a look. Thanks!
> > > > 
> > > > Everyone:
> > > > 
> > > > This patch series is v14 of the driver for supervisory processor found
> > > > on RAVE series of devices from ZII. Supervisory processor is a PIC
> > > > microcontroller connected to various electrical subsystems on RAVE
> > > > devices whose firmware implements protocol to command/qery them.
> > > > 
> > > > NOTE:
> > > > 
> > > >   * This driver dependends on crc_ccitt_false(), added by
> > > >     2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next', the patch
> > > >     was pulled in by Andrew Morton and is currently avaiting users, so
> > > >     this series might have to go in through Andrew's tree
> > > > 
> > > 
> > > Strictly speaking, the solution would be for Andrew to provide an immutable
> > > branch with the above, for Rob to provide an immutable branch based on Andrew's
> > > branch, adding the serdev drivers, for Lee to provide yet another immutable
> > > branch with all those plus the mfd driver, and for Wim to pick it all up
> > > into the watchdog tree.
> > 
> > I think that's the craziest thing I've ever heard. ;)  Only 1
> > immutable branch is required, which can be pulled in by everyone.
> > 
> > Bear with me.  Pull-request to follow.
> 
> Did the compatible-strings issue get sorted out? That is, that the cell
> drivers were matching on the parent compatible string to determine
> their type instead of encoding that in their own compatible strings. Is
> that desired (and recommended)?

Looks like they are still doing that.

I'd suggest that it was sub-optimal.  It would be better to pass
platform information through pdata or ddata IMHO.  Or yes, use the
child compatible strings (if they differ from platform to platform).

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux