On Sat, 16 Dec 2017, Guenter Roeck wrote: > On 12/07/2017 08:27 AM, Andrey Smirnov wrote: > > Lee: > > > > This patch set has been marinating out there for a while now and > > yours, I belive, is that last signature I need to start pushing it for > > inclusion. I'd really appreciate if you could spare some of your time > > to give it a look. Thanks! > > > > Everyone: > > > > This patch series is v14 of the driver for supervisory processor found > > on RAVE series of devices from ZII. Supervisory processor is a PIC > > microcontroller connected to various electrical subsystems on RAVE > > devices whose firmware implements protocol to command/qery them. > > > > NOTE: > > > > * This driver dependends on crc_ccitt_false(), added by > > 2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next', the patch > > was pulled in by Andrew Morton and is currently avaiting users, so > > this series might have to go in through Andrew's tree > > > > Strictly speaking, the solution would be for Andrew to provide an immutable > branch with the above, for Rob to provide an immutable branch based on Andrew's > branch, adding the serdev drivers, for Lee to provide yet another immutable > branch with all those plus the mfd driver, and for Wim to pick it all up > into the watchdog tree. I think that's the craziest thing I've ever heard. ;) Only 1 immutable branch is required, which can be pulled in by everyone. Bear with me. Pull-request to follow. > That seems to be a bit complicated. I would suggest for Lee to pick it all up. > If Lee is busy and ok with it, I'll be happy to pick it all up and submit to > Linus as a separate pull request during the next commit window. > > Lee, Andrew, any thoughts/comments ? > > Thanks, > Guenter > > > Changes since [v13]: > > > > - Fixed incorrect MFD driver menuconfig entry placement > > > > Changes since [v12]: > > > > - Minor comment inconsistencies fixes in rave-sp.c > > > > Changes since [v11]: > > > > - Fix incorrect include in rave-sp-wdt.c as uncovered by kernel > > test robot > > > > Changes since [v10]: > > > > - Collected Acked-by from Rob and Reviewed-by from Guenter > > > > - Incorporated watchdog driver feedback from Gunter and Johan > > > > - Incorporated Johan's feedback for the rest of the code > > > > Changes since [v9]: > > > > - Converted watchdog driver to use watchdog_active() instead of > > watchdog_hw_running() and replaced WARN_ON with a regular error > > message as per feedback from Guenter > > > > - Changed rave_sp_wdt_start() to set WDOG_HW_RUNNING only if > > communicating with hardware was sucessful > > > > - Collected Reviewd-by from Sebastian (for serdev related patches) > > > > - Collected Acked-by from Rob (for watchdog DT bindings) > > > > Changes since [v8]: > > > > - Driver moved from drivers/platform to drivers/mfd > > > > - Collected Reviewed-by from Guenter (for patches 1, 2 and 3) > > > > - Incorporated feedback from Guenter into watchdog driver > > > > - Incorporated feedback from Rob into watchdog DT bindings > > > > - Removed struct rave_sp_rsp_status, which was a leftover from v5 > > -> v6 code removal. > > > > - Fixed minor problems reported by checkpatch > > > > Changes since [v7]: > > > > - Added watchdog driver to the patchset, so it would be easier to > > understand how parent/children drivers are tied together > > > > - Added serdev patches to implement devm_serdev_device_open() and make .remove optional > > > > - "Added" missing serdev_device_close() by converting the driver > > to use devm_serdev_device_open() > > > > - Converted the driver to use devm_of_platform_populate() > > > > - Removed needless dependency on MFD_CORE > > > > - Removed dependency on SERIAL_DEV_CTRL_TTYPORT > > > > Changes since [v6]: > > > > - Patch 2/2 has been applied by Lee so it is no longer a part of the series > > > > - Removed all sysfs and debugfs attribute to reduce the scope of > > the driver propsed for inclusion. This is not a critical to have > > feature and can be added/discussed later. > > > > Changes since [v5]: > > > > - Fixed a build break, introduced by a last minute change in [v5] > > > > - Moved majority of attributes that were exposed over sysfs to debugfs > > > > - Document remaining sysfs attributes in Documentation/ABI/testing/sysfs-platform-rave-sp > > > > Changes since [v4]: > > > > - Replaced usage of DEVICE_ATTR with DEVICE_ATTR_RW > > > > - Fixed a number of warnings produces by sparse tool > > > > - Incorporated event more feedback from Andy Shevchenko > > > > - Collected Reviewed-by from Andy > > > > Changes since [v3]: > > > > - Re-collected lost Acked-by from Rob > > > > - Incorporated further feedback from Andy Shevchenko > > > > - Dropped useless change (stray newline) to drivers/mfd/Makefile > > > > Changes since [v2]: > > > > - Fixed swapped command codes in rave_sp_common_get_boot_source() > > and rave_sp_common_set_boot_source() revealed by further testing > > of the code > > > > - Incorporated feedback from Andy Shevchenko > > > > Changes since [v1]: > > > > - Updated wording in DT-bindings as per Rob's request. > > > > - Collected Rob's Acked-by for patch 2/2 > > > > Feedback is greatly appreciated! > > > > Thanks, > > Andrey Smirnov > > > > [v13] lkml.kernel.org/r/20171204161118.19558-1-andrew.smirnov@xxxxxxxxx > > [v12] lkml.kernel.org/r/20171109160556.17018-1-andrew.smirnov@xxxxxxxxx > > [v11] lkml.kernel.org/r/20171106152935.16920-1-andrew.smirnov@xxxxxxxxx > > [v10] lkml.kernel.org/r/20171031163656.24552-1-andrew.smirnov@xxxxxxxxx > > [v9] lkml.kernel.org/r/20171025190421.18415-1-andrew.smirnov@xxxxxxxxx > > [v8] lkml.kernel.org/r/20171018170136.12347-1-andrew.smirnov@xxxxxxxxx > > [v7] lkml.kernel.org/r/20171013061321.31252-2-andrew.smirnov@xxxxxxxxx > > [v6] lkml.kernel.org/r/20170828163131.24815-2-andrew.smirnov@xxxxxxxxx > > [v5] lkml.kernel.org/r/20170728142704.11156-1-andrew.smirnov@xxxxxxxxx > > [v4] lkml.kernel.org/r/20170725184450.13171-1-andrew.smirnov@xxxxxxxxx > > [v3] lkml.kernel.org/r/20170724150915.4824-1-andrew.smirnov@xxxxxxxxx > > [v2] lkml.kernel.org/r/20170718175604.11735-1-andrew.smirnov@xxxxxxxxx > > [v1] lkml.kernel.org/r/20170710170449.4544-1-andrew.smirnov@xxxxxxxxx > > > > Andrey Smirnov (5): > > serdev: Make .remove in struct serdev_device_driver optional > > serdev: Introduce devm_serdev_device_open() > > mfd: Add driver for RAVE Supervisory Processor > > watchdog: Add RAVE SP watchdog driver > > dt-bindings: watchdog: Add bindings for RAVE SP watchdog driver > > > > .../bindings/watchdog/zii,rave-sp-wdt.txt | 39 ++ > > Documentation/driver-model/devres.txt | 3 + > > drivers/mfd/Kconfig | 8 + > > drivers/mfd/Makefile | 2 + > > drivers/mfd/rave-sp.c | 660 +++++++++++++++++++++ > > drivers/tty/serdev/core.c | 31 +- > > drivers/watchdog/Kconfig | 7 + > > drivers/watchdog/Makefile | 1 + > > drivers/watchdog/rave-sp-wdt.c | 357 +++++++++++ > > include/linux/mfd/rave-sp.h | 56 ++ > > include/linux/serdev.h | 1 + > > 11 files changed, 1163 insertions(+), 2 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt > > create mode 100644 drivers/mfd/rave-sp.c > > create mode 100644 drivers/watchdog/rave-sp-wdt.c > > create mode 100644 include/linux/mfd/rave-sp.h > > > -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
