On Mon, Dec 18, 2017 at 2:13 PM, Michal Simek <michal.simek@xxxxxxxxxx> wrote: > On 15.12.2017 14:26, Arnd Bergmann wrote: >> In Fri, Dec 15, 2017 at 8:24 AM, Dhaval Shah <dhaval.shah@xxxxxxxxxx> wrote: >>> Xilinx ZYNQMP logicoreIP Init driver is based on the new >>> LogiCoreIP design created. This driver provides the processing system >>> and programmable logic isolation. Set the frequency based on the clock >>> information get from the logicoreIP register set. >>> >>> It is put in drivers/misc as there is no subsystem for this logicoreIP. >>> >>> Signed-off-by: Dhaval Shah <dshah@xxxxxxxxxx> >> >> After giving this some more thought, I'd suggest you move the driver to >> drivers/soc/xilinx or drivers/soc/zynq instead of drivers/misc/, and have >> it merged by Michal Simek as a driver patch that will go through arm-soc. > > I have not a problem of creating drivers/soc/xilinx/ location for this > driver. It is not zynq (arm32) but zynqmp(arm64) device where this > driver can be used. As far as I understand it is memory mapped soft IP > which could be also accessed by soft core CPU. Ok. I wouldn't be worried about having a zynq directory for stuff that is common between zynq and zynqmp, but the soft code CPU case wouldn't make that ideal. > It means drivers/soc/xilinx could be shared by all xilinx platforms anyway. > We have been discussing that openrisc cases and for sure if someone > wants to enable this driver there using misc location would be one > option but I also think that using drivers/soc/xilinx location is not a > bad option because it is very unlikely that anybody tries it. > > Arnd: misc or drivers/soc/xilinx? drivers/soc/xilinx please, thanks for the clarification. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html