Hi Miquèl, On Thu, Dec 14, 2017 at 11:30:05AM +0100, Miquel Raynal wrote: > From: Baruch Siach <baruch@xxxxxxxxxx> > > The AP806 component is integrated in the Armada 8k and 7k lines of > processors. > > The thermal sensor sample field on the status register is a signed > value. Extend armada_get_temp() to handle signed values. > > Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxxxxxxxxx> > --- [...] > +static void armada_ap806_init_sensor(struct platform_device *pdev, > + struct armada_thermal_priv *priv) > +{ > + u32 reg; > + > + if (!priv->control0) { > + dev_err(&pdev->dev, > + "Cannot access to control0 (control LSB) register\n"); > + return; > + } With the probe time control area size validation this check would not be needed. baruch > + > + reg = readl_relaxed(priv->control0); > + reg &= ~CONTROL0_TSEN_RESET; > + reg |= CONTROL0_TSEN_START | CONTROL0_TSEN_ENABLE; > + writel(reg, priv->control0); > + msleep(10); > +} -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@xxxxxxxxxx - tel: +972.52.368.4656, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html