On Wed, Dec 6, 2017 at 1:55 AM, André Przywara <andre.przywara@xxxxxxx> wrote: > On 01/12/17 09:56, Linus Walleij wrote: >> It is a valid cause. Just >> has to be weighed with other stuff, like maintainability, debuggability, >> maintainers viewpoint. ... > > So to keep Maxime happy I actually designed this "driver" more like a > shim: to generate the table the current driver expects from the DT, and > actually not touching the existing driver at all. > So maintainability should actually be less of a concern: the driver will > just work with whatever one throws at it from the DT side, without > requiring frequent changes or additions. > In the moment we still need to write, review and merge *data* files for > each new SoC. And as I mentioned before, Allwinner decided to push for > new, slightly different chips every few months, so there will be more to > come. With at least the pinctrl driver out of the way we have one > problem less to worry about. I think you need mainly to convince Maxime that this is something that he wants to maintain, going forward. I am as subsystem maintainer pretty pleased as long as standard properties etc are used to encode the data into the devicetree, and DT maintrainers are not actively vetoing what you do. If it leads to a conflict between Allwinner maintainers it is not worth the effort for reasons that are social rather than technical. To me it is a very nice but as with all volunteer communities also very vulnerable endavour. Please make sure not to push your point so hard that it hurts your our your colleagues feelings. I know people are passionate about their ideas, which is usally good but also scare me sometimes because they sometimes become so passionate that it makes them bad team players. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
