Dear Masami-san, On Tue, Dec 12, 2017 at 3:29 AM, Masami Hiramatsu <masami.hiramatsu@xxxxxxxxxx> wrote: [...] > Then what I'm considering is copyright notice lines. Those are usually > treat as the header lines, not single line. So > >> +// SDPX-License-Identifier: GPL-2.0 >> +// sni_ave.c - Socionext UniPhier AVE ethernet driver >> +// Copyright 2014 Panasonic Corporation >> +// Copyright 2015-2017 Socionext Inc. > > is acceptable? or should we keep C-style header lines for new drivers? > >> +// SDPX-License-Identifier: GPL-2.0 >> +/* >> + * sni_ave.c - Socionext UniPhier AVE ethernet driver >> + * Copyright 2014 Panasonic Corporation >> + * Copyright 2015-2017 Socionext Inc. >> + */ > > I just concern that those lines are not "single". that's all. :) My voice carries the weight of a down feather in this discussion and to me the benefit of the first form is that you have removed two lines. Both forms work fine. -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
