Dear Kunihiko-san, On Mon, Dec 11, 2017 at 8:57 AM, Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx> wrote: > The UniPhier platform from Socionext provides the AVE ethernet > controller that includes MAC and MDIO bus supporting RGMII/RMII > modes. The controller is named AVE. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx> > Signed-off-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> [...] > --- /dev/null > +++ b/drivers/net/ethernet/socionext/Makefile > @@ -0,0 +1,5 @@ > +# SPDX-License-Identifier: GPL-2.0 You are correctly using SPDX ids here.... > +obj-$(CONFIG_SNI_AVE) += sni_ave.o > diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c > new file mode 100644 > index 0000000..7b293c2 > --- /dev/null > +++ b/drivers/net/ethernet/socionext/sni_ave.c > @@ -0,0 +1,1744 @@ > +/** > + * sni_ave.c - Socionext UniPhier AVE ethernet driver > + * > + * Copyright 2014 Panasonic Corporation > + * Copyright 2015-2017 Socionext Inc. > + * > + * This program is free software: you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 of > + * the License as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ ... then I guess you could also use them here, replacing at least 7 lines of boilerplate by a single id line? > +// SDPX-License-Identifier: GPL-2.0 And if you go C++ style all the way, this could be even more compact: > +// SDPX-License-Identifier: GPL-2.0 > +// sni_ave.c - Socionext UniPhier AVE ethernet driver > +// Copyright 2014 Panasonic Corporation > +// Copyright 2015-2017 Socionext Inc. Thank you for your kind consideration! -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
