On Fri, Jan 31, 2014 at 03:18:50AM +0100, Sebastian Hesselbarth wrote: > On 01/30/2014 09:25 PM, Andrew Lunn wrote: > >On Thu, Jan 30, 2014 at 07:50:34PM +0100, Sebastian Hesselbarth wrote: > >>On 01/30/2014 07:29 PM, Andrew Lunn wrote: > >>>On Tue, Jan 28, 2014 at 01:39:12AM +0100, Sebastian Hesselbarth wrote: > >>>>This patch set is one required step for Dove to hop into mach-mvebu. > >>>>Until now, pinctrl-dove was hardcoding some registers that do not > >>>>directly belong to MPP core registers. This is not compatible with > >>>>what we want for mach-mvebu. > >>> > >>>I think there might be something wrong here.... > >> > >>There _is_ something wrong. I'll have a look at it. For the record, > >>what SoC are you testing with? From the base address, I guess it is > >>Kirkwood? > > > >Yes, Kirkwood. Sorry for not saying. > > This time I push a branch before sending out the patches. Also, I > think I'll postpone removal of hardcoded addresses until this is > sorted out. The patch set was growing way to quick and I have to > do this step-by-step for me and everybody else to actually understand ;) > > So, at least the MVEBU guys should test the following branch on > their SoCs. Again, I have tested Dove and now confirmed that settings > are still correct. The others are compile-tested. > > https://github.com/shesselba/linux-dove.git unstable/mvebu-pinctrl-v3.14_v3 Hi Sebastian Tested on Kirkwood. /debug/pinctrl is now identical with and without the patch. I've not looked at the actual patches, but please add a Tested-by: Andrew Lunn <andrew@xxxxxxx> Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html