Re: [PATCH v7 10/13] dt-bindings: Add qcom slimbus controller bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Thanks for the review,

On 16/11/17 05:19, Rob Herring wrote:
+	entry should be used.
+ - reg-name for slew rate: "slew"
reg-names

I'd prefer it be explicit as to which compatibles do or don't have this
register.
Makes sense, I will take this in before sending next version.

+
+Example:
+
+	slim@28080000 {
+		compatible = "qcom,apq8064-slim", "qcom,slim";
+		reg = <0x28080000 0x2000>,
error                                    ^

thanks for spotting.. will fix this.
+		interrupts = <0 33 0>;
+		clocks = <&lcc SLIMBUS_SRC>, <&lcc AUDIO_SLIMBUS_CLK>;
+		clock-names = "iface", "core";
+		#address-cells = <2>;
+		#size-cell = <0>;
+
+		codec: wcd9310@1,0{
Use generic node names:

wcd9310: audio-codec@1,0
Yep, will do that.

thanks,
srini

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux