From: Patrick Bruenn <p.bruenn@xxxxxxxxxxxx> rtc-imxdi driver is not compatible with imx53-rtc like the example suggested. Only the raw timestamp register offsets match by accident, which has the effect, that during startup/shutdown system clock syncronization with rtc seems to work for imx53, too. However hwclock and rtctest, will not work as expected on imx53. To avoid future reverts like [1], we should adjust the documentation. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-November/542312.html Signed-off-by: Patrick Bruenn <p.bruenn@xxxxxxxxxxxx> --- To: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> To: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> Cc: Rob Herring <robh+dt@xxxxxxxxxx> Cc: Mark Rutland <mark.rutland@xxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Cc: linux-rtc@xxxxxxxxxxxxxxx (open list:REAL TIME CLOCK (RTC) SUBSYSTEM) Cc: devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Cc: linux-kernel@xxxxxxxxxxxxxxx (open list) Cc: Fabio Estevam <fabio.estevam@xxxxxxx> Cc: Juergen Borleis <jbe@xxxxxxxxxxxxxx> Cc: Noel Vellemans <Noel.Vellemans@xxxxxxxxxxxxx> Cc: Shawn Guo <shawnguo@xxxxxxxxxx> --- Documentation/devicetree/bindings/rtc/imxdi-rtc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt index 323cf26374cb..af853b0ceac5 100644 --- a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt +++ b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt @@ -1,6 +1,6 @@ * i.MX25 Real Time Clock controller -This binding supports the following chips: i.MX25, i.MX53 +This binding supports the following chips: i.MX25 Required properties: - compatible: should be: "fsl,imx25-rtc" @@ -14,7 +14,7 @@ Optional properties: Example: rtc@80056000 { - compatible = "fsl,imx53-rtc", "fsl,imx25-rtc"; + compatible = "fsl,imx25-rtc"; reg = <0x80056000 2000>; interrupts = <29 56>; }; -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html