On Sun, Jan 19, 2014 at 07:56:52PM -0800, Olof Johansson wrote: > This is a small series enhancing the MMC core code to power on modules > before the host in cases where needed, and the corresponding DT bindings > changes. > > I've got some other issues to debug on the Chromebook, i.e. the interface > doens't actually work. So far it seems unrelated to this patch set so > it's worth posting this and get things going since others need the same > functionality (i.e Cubox-i). > > As mentioned in the patch in the series, I haven't implemented power-down > yet, I wanted to make sure that the power-on side will be adequate for > those who are looking to use it right away. > > Comments/test reports/etc welcome. So, I thought I'd give this a go on the Cubox-i4, and... it doesn't work there. It's not your patches, it's down to sdhci-esdhc-imx.c not using mmc_of_parse() at all, so those new properties have no way to be used there. It doesn't look like it could in its current form use mmc_of_parse(), as the imx code manually parses some of the generic properties to hand them into the sdhci layer. This looks icky, and it looks like something that should be fixed - why should drivers be parsing the core attributes themselves? -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
