Hi, On 01/11/2017 at 08:01:20 -0700, Eric Nelson wrote: > Note that alarms are not currently implemented. > > 64 bytes of nvmem is supported and exposed in > sysfs (# is the instance number, starting with 0): > > /sys/bus/nvmem/devices/pcf85363-#/nvmem > > Signed-off-by: Eric Nelson <eric@xxxxxxxxxx> > Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx> > --- > V2 addresses a couple of issues highlighted by Fabio Estevam > 1. Kconfig updated to select REGMAP_I2C > 2. Switch to of_device_id from i2c_device_id for driver matching > > V3 adds interrupts as an optional property in device tree bindings > > drivers/rtc/Kconfig | 13 ++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-pcf85363.c | 221 +++++++++++++++++++++ > 4 files changed, 252 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/pcf85363.txt > create mode 100644 drivers/rtc/rtc-pcf85363.c > I've tested it (thanks to Fabio, I received one a few weeks ago) Applied with the following change: --- a/drivers/rtc/rtc-pcf85363.c +++ b/drivers/rtc/rtc-pcf85363.c @@ -194,7 +194,6 @@ static int pcf85363_probe(struct i2c_client *client, pcf85363->nvmem_cfg.reg_write = pcf85363_nvram_write; pcf85363->nvmem_cfg.priv = pcf85363; pcf85363->rtc->nvmem_config = &pcf85363->nvmem_cfg; - pcf85363->rtc->nvram_old_abi = true; pcf85363->rtc->ops = &rtc_ops; return rtc_register_device(pcf85363->rtc); nvram_old_abi must not be used for new drivers and will generate warning when the (undocumented) ABI is used anyway. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html