On Tue, Oct 17, 2017 at 5:24 PM, Eric Nelson <eric@xxxxxxxxxx> wrote:
> Hi Rob,
>
>
> On 10/17/2017 01:06 PM, Rob Herring wrote:
>>
>> On Wed, Oct 11, 2017 at 08:56:30AM -0700, Eric Nelson wrote:
>>>
>>> Note that alarms are not currently implemented.
>>>
>>> 64 bytes of nvmem is supported and exposed in
>>> sysfs (# is the instance number, starting with 0):
>>>
>>> /sys/bus/nvmem/devices/pcf85363-#/nvmem
>>>
>>> Signed-off-by: Eric Nelson <eric@xxxxxxxxxx>
>>> ---
>>> V2 addresses a couple of issues highlighted by Fabio Estevam
>>> 1. Kconfig updated to select REGMAP_I2C
>>> 2. Switch to of_device_id from i2c_device_id for driver matching
>>>
>>> Documentation/devicetree/bindings/rtc/pcf85363.txt | 16 ++
>>> drivers/rtc/Kconfig | 13 ++
>>> drivers/rtc/Makefile | 1 +
>>> drivers/rtc/rtc-pcf85363.c | 221
>>> +++++++++++++++++++++
>>> 4 files changed, 251 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/rtc/pcf85363.txt
>>> create mode 100644 drivers/rtc/rtc-pcf85363.c
>>>
>>> diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt
>>> b/Documentation/devicetree/bindings/rtc/pcf85363.txt
>>> new file mode 100644
>>> index 0000000..5fddb9f
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt
>>> @@ -0,0 +1,16 @@
>>> +NXP PCF85363 Real Time Clock
>>> +============================
>>> +
>>> +Required properties:
>>> +- compatible: Should contain "nxp,pcf85363".
>>> +- reg: I2C address for chip.
>>> +
>>> +Example:
>>> +
>>> +pcf85363: pcf85363@51 {
>>> + compatible = "nxp,pcf85363";
>>> + reg = <0x51>;
>>> +};
>>> +
>>> +Note that alarms are not yet supported, so a specifier for
>>> +"interrupts" will be ignored.
>>
>>
>> Irrelevant to the binding. That's a driver feature (or lack of). If the
>> device has an interrupt line, you should document it. It can be optional
>> though.
>>
>
> That's what I was attempting do do in an awkward way.
>
> Since the driver doesn't support interrupts or alarms at the moment,
> I'll remove this note.
>
> The chip does have an interrupt pin, but the board I have doesn't
> have it connected.
Then just document "interrupts" as optional.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
