Hi,
On Thu, 26 Oct 2017 16:10:54 -0200 Fabio Estevam wrote:
> On Thu, Oct 26, 2017 at 1:25 PM, Marco Franchi <marco.franchi@xxxxxxx> wrote:
> > The following build warning is seen with W=1:
> >
> > Warning (unit_address_vs_reg): Node /soc/aips@60000000/ethernet@63fec000/ethernet-phy@0 has a unit name, but no reg property
> >
> > Fix this warning by adding reg property from such node and, consequently,
> > includes a mdio node into the fec node, with the 'address-cells' and
> > 'size-cells' to avoid these other following warnings:
> >
> > Warning (reg_format): "reg" property in /soc/aips@60000000/ethernet@63fec000/ethernet-phy@0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> > Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/aips@60000000/ethernet@63fec000/ethernet-phy@0
> > Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/aips@60000000/ethernet@63fec000/ethernet-phy@0
> >
> > Signed-off-by: Marco Franchi <marco.franchi@xxxxxxx>
>
> Lothar, could you please test it?
>
> > ---
> > Change since v4:
> > -pass the 'address-cells' and 'size-cells' values using a mdio node
> > -change message log
> > arch/arm/boot/dts/imx53-tx53.dtsi | 14 ++++++++++----
> > 1 file changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> > index 71b58b6..a22e461 100644
> > --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> > @@ -225,10 +225,16 @@
> > mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
> > status = "okay";
> >
> > - phy0: ethernet-phy@0 {
> > - interrupt-parent = <&gpio2>;
> > - interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> > - device_type = "ethernet-phy";
> > + mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + phy0: ethernet-phy@0 {
> > + reg = <0>;
> > + interrupt-parent = <&gpio2>;
> > + interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> > + device_type = "ethernet-phy";
> > + };
> > };
> > };
> >
> > --
> > 2.7.4
> >
>
Tested-by: <LW@xxxxxxxxxxxxxxxxxxx>
Acked-by: <LW@xxxxxxxxxxxxxxxxxxx>
Lothar Waßmann
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
