Hi Rob, On Mon, Oct 23, 2017 at 05:28:50PM -0500, Rob Herring wrote: > On Sun, Oct 15, 2017 at 12:48:02PM +0800, Shawn Guo wrote: > > From: Jianguo Sun <sunjianguo1@xxxxxxxxxx> > > > > Add combo phy driver for HiSilicon STB SoCs. This phy can be > > used as pcie-phy, sata-phy or usb-phy. > > > > Signed-off-by: Jianguo Sun <sunjianguo1@xxxxxxxxxx> > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > > --- > > .../bindings/phy/phy-hi3798cv200-combphy.txt | 21 ++ > > Please split bindings to separate patch especially for new ones. Yeah, have already done that in v2 [1]. > > drivers/phy/Makefile | 1 + > > drivers/phy/hisilicon/Kconfig | 9 + > > drivers/phy/hisilicon/Makefile | 1 + > > drivers/phy/hisilicon/phy-histb-combphy.c | 236 +++++++++++++++++++++ > > 5 files changed, 268 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3798cv200-combphy.txt > > create mode 100644 drivers/phy/hisilicon/phy-histb-combphy.c > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-hi3798cv200-combphy.txt b/Documentation/devicetree/bindings/phy/phy-hi3798cv200-combphy.txt > > new file mode 100644 > > index 000000000000..c7121cdcaed9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/phy-hi3798cv200-combphy.txt > > @@ -0,0 +1,21 @@ > > +HiSilicon STB PCIE/SATA/USB3 PHY > > + > > +Properties: > > +- compatible: Should be "hisilicon,hi3798cv200-combphy" > > +- #phy-cells: Should be 1. The cell number is used to select the phy mode: > > + 0: PCIe mode > > + 1: USB 3.0 mode > > + 2: SATA mode > > +- clocks: The phandle to clock provider and clock specifier pair. > > +- resets: The phandle to reset controller and reset specifier pair. > > +- hisilicon,peripheral-syscon: The phandle to the peripheral controller. > > Could just be a child of the syscon instead? It should be doable, but I do not fully understand the benefits of doing that. Shawn [1] https://www.spinics.net/lists/devicetree/msg199804.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
