On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandagatla@xxxxxxxxxx wrote:
> ---
> Documentation/devicetree/bindings/slimbus/bus.txt | 57 ++
> Documentation/slimbus/summary | 109 ++++
This is a 40k patch which is a bit offputting for review. Splitting the
docs out would help this a bit.
> +static int slim_boot_child(struct device *dev, void *unused)
> +{
> + struct slim_driver *sbdrv;
> + struct slim_device *sbdev = to_slim_device(dev);
> +
> + if (sbdev && sbdev->dev.driver) {
> + sbdrv = to_slim_driver(sbdev->dev.driver);
> + if (sbdrv->boot_device)
> + sbdrv->boot_device(sbdev);
> + }
> + return 0;
> +}
We silently don't boot a device if it hasn't got a driver - is that the
right thing? It feels like the silencing should be in the calling
function.
> +ret_assigned_laddr:
> + mutex_unlock(&ctrl->m_ctrl);
> + if (exists || ret)
> + return ret;
> +
> + dev_info(&ctrl->dev, "setting slimbus l-addr:%x, ea:%x,%x,%x,%x\n",
> + *laddr, e_addr->manf_id, e_addr->prod_code,
> + e_addr->dev_index, e_addr->instance);
dev_dbg()?
Attachment:
signature.asc
Description: PGP signature
