Re: [PATCH] firmware: meson-sm: use generic compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Rob Herring <robh@xxxxxxxxxx> writes:

> On Thu, Oct 12, 2017 at 03:47:43PM +0200, Jerome Brunet wrote:
>> The meson secure monitor seems to be compatible with more SoCs than
>> initially thought. Let's use the most generic compatible he have in
>> DT instead of the gxbb specific one
>> 
>> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/firmware/meson/meson_sm.txt | 4 ++--
>>  drivers/firmware/meson/meson_sm.c                             | 4 ++--
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> Seems like a pointless, not backwards compatible change to me.

I've verified that it's backwards compatible with existing upstream DTs.

> end, it's just a string to match on. Who cares what the string is.

As platform maintiner, I very much care what the strings are and I want
it to be coherent with the platform generic names, and I want the
SoC-specific strings to correspond to the actual SoC names.

Kevin



--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux