On Mon, 2014-01-27 at 19:34 +0400, Alexey Charkov wrote: > 2014/1/27 Ben Hutchings <ben@xxxxxxxxxxxxxxx>: > > On Mon, 2014-01-27 at 15:51 +0400, Alexey Charkov wrote: > >> This should make the driver usable with VIA/WonderMedia ARM-based > >> Systems-on-Chip integrated Rhine III adapters. Note that these > >> are always in MMIO mode, and don't have any known EEPROM. > > [...] > >> --- a/drivers/net/ethernet/via/Kconfig > >> +++ b/drivers/net/ethernet/via/Kconfig > >> @@ -19,7 +19,7 @@ if NET_VENDOR_VIA > >> > >> config VIA_RHINE > >> tristate "VIA Rhine support" > >> - depends on PCI > >> + depends on (PCI || USE_OF) > >> select CRC32 > >> select MII > >> ---help--- > > > > This seems like the right thing to do, but it means you need to add > > #ifdef CONFIG_PCI and #ifdef CONFIG_USE_OF around the driver structures > > and related functions. > > Frankly, I would like to avoid that if possible (as pointed out in the > cover email), as I believe we would get a cleaner driver without > #ifdef. This is also the way it was done in via-velocity, and it works > just fine. OK, I'm surprised that all the PCI functions have dummy definitions. > > You should compile-test in configurations that have just one of those > > dependencies enabled. > > This has been compile-tested and runtime-tested in OF-only > configuration on WM8950, and Roger also tested it in PCI-only > configuration, so it seems to work fine. [...] Good, then I have no objection. Ben. -- Ben Hutchings If at first you don't succeed, you're doing about average.
Attachment:
signature.asc
Description: This is a digitally signed message part
