On Sun, Sep 24, 2017 at 09:05:26PM +0200, Martin Blumenstingl wrote: > This is the successor to Carlo Caione's "Add support for Amlogic Meson > MMC driver" series (v5) from [0]. > This new driver is for the "SDIO" controller found in Amlogic Meson6, > Meson8 and Meson8b SoCs and supports an internal mux to allow connecting > three cards to it. > > > changes since RFC v1 at [1]: > - added COMMON_CLK dependency as reported by the kbuild test robot > - use of_platform_device_{create,destroy} instead of open-coding it's > logic > - moved struct device (which was an array) from meson_mx_mmc_host to > the corresponding meson_mx_mmc_slot > - use struct mmc_command's busy_timeout instead of hard-coding the > timeout values in meson_mx_mmc_start_cmd() > - don't use arrays with only one element for the clock parents in > meson_mx_mmc_register_clks() > - removed the wrapper functions meson_mx_mmc_readl() meson_mx_mmc_writel() > - allow setting the MMC clock to 0 for UHS speed mode (the actual > hardware clock cannot be gated as far as I know, so instead the > lowest supported rate is chosen) > - remove unused #include <linux/init.h> > - add MMC_CAP_ERASE > - removed multiple slot support after discussing this with Ulf > (this is a feature that needs to be part of the MMC core before drivers > can use it) > - removed SDIO interrupt support (as I currently don't have a way to > test it) > - merge meson_mx_mmc_apply_ios into meson_mx_mmc_set_ios (as that's > the only place where it's needed after removing multiple slot support) > - updated the commit message of the driver patch to indicate the > difference between the meson-mx-sdio.c and meson-gx.c (and the "still > missing SDHC") driver > - NOTE: I did not add Rob's ACK on the dt-bindings patch because I > introduced the "mmc-slot" compatible for the child nodes as suggested > by Ulf (and I want confirmation from the DT maintainers that I did this > correctly) Didn't slot support get removed as no h/w really uses that feature? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html