On Wed, Sep 20, 2017 at 03:52:57PM -0500, Rob Herring <robh@xxxxxxxxxx> wrote: > On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote: > > The driver used to be developed with legacy GPIO API support. It's > > better to use descriptor-based interface for several reasons. First > > of all the legacy API doesn't support the ACTIVE_LOW/HIGH flag of dts > > nodes, which is essential since different hardware may have different > > GPIOs connectivity including the logical value inversion. Secondly, > > by requesting the reset GPIO descriptor the driver prevent the other > > applications from changing its value. And last but not least the > > legacy GPIO interface should be avoided in the new code due to it > > obsolescence. > > All this has nothing to do with the binding. Please make the binding > change separate and state why it should be optional. > Ok. > > > > Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx> > > --- > > Documentation/devicetree/bindings/usb/usb251xb.txt | 2 +- > > drivers/usb/misc/usb251xb.c | 34 +++++++++------------- > > 2 files changed, 15 insertions(+), 21 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
