Re: [PATCH v2 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Vladimir,

On Thu, Sep 14, 2017 at 4:19 PM, Vladimir Barinov
<vladimir.barinov@xxxxxxxxxxxxxxxxxx> wrote:
> This supports PCA9539 gpio expanders on I2C2 bus on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -48,6 +48,28 @@
>         status = "okay";
>  };
>
> +&i2c2 {
> +       gpio_exp_74: gpio@74 {
> +               compatible = "nxp,pca9539";

According to the schematics, this is the TI TCA9539, an enhanced version
of the NXP PCA9539. So I'd expect "ti,tca9539".

However, using the latter may not work (I didn't try), as pca953x_id[]
lists both parts, while pca953x_dt_ids[] lists only the NXP part number.

> +               reg = <0x74>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               interrupt-controller;
> +               interrupt-parent = <&gpio6>;
> +               interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> +       };
> +
> +       gpio_exp_75: gpio@75 {
> +               compatible = "nxp,pca9539";

Likewise.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux