Hi Geert-san,
> From: Geert Uytterhoeven
> Sent: Wednesday, September 13, 2017 6:22 PM
>
> Hi Shimoda-san,
>
> On Wed, Sep 13, 2017 at 8:52 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > This patch adds GPIO device nodes for r8a77995.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > @@ -139,6 +139,118 @@
> > #power-domain-cells = <1>;
> > };
> >
> > + gpio0: gpio@e6050000 {
> > + compatible = "renesas,gpio-r8a77995",
> > + "renesas,rcar-gen3-gpio",
> > + "renesas,gpio-rcar";
> > + reg = <0 0xe6050000 0 0x50>;
> > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> > + #gpio-cells = <2>;
> > + gpio-controller;
> > + gpio-ranges = <&pfc 0 0 9>;
> > + #interrupt-cells = <2>;
> > + interrupt-controller;
> > + clocks = <&cpg CPG_MOD 912>;
> > + power-domains = <&cpg>;
>
> All nodes lack the power domain index (32, to be replaced by
> R8A77995_PD_ALWAYS_ON later):
>
> power-domains = <&sysc 32>;
The r8a77995.dtsi file already uses R8A77995_PD_ALWAYS_ON in scif2 node.
So, should I fix this patch like the following?
power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> > + resets = <&cpg 912>;
> > + };
>
> With that fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Thank you for the review!
Best regards,
Yoshihiro Shimoda
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
