On Fri, Aug 18, 2017 at 11:00:19AM -0500, Li Xu wrote:
This is mostly good, there's a couple of stylistic issues - please send
incremental patches fixing them:
> + case SND_SOC_DAPM_POST_PMU:
> + regmap_update_bits(cs43130->regmap, CS43130_DSD_PATH_CTL_1,
> + CS43130_MUTE_MASK, 0);
> + switch (cs43130->dev_id) {
> + case CS43130_CHIP_ID:
> + case CS4399_CHIP_ID:
> + regmap_multi_reg_write(cs43130->regmap, unmute_seq,
> + ARRAY_SIZE(unmute_seq));
> + }
I'd expect to see break statements at the end of each case in a switch -
this is an issue throughout the driver.
> + if (cs43130->reset_gpio)
> + gpiod_set_value_cansleep(cs43130->reset_gpio, 0);
The check here isn't needed and isn't done elsewhere in the driver, best
to remove it for consistency.
Attachment:
signature.asc
Description: PGP signature
