* Tomi Valkeinen <tomi.valkeinen@xxxxxx> [170829 05:25]:
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
> On 29/08/17 15:10, Sebastian Reichel wrote:
>
> >> Do we even want to add SGX to the .dts? We don't have proper drivers for
> >> SGX. If we ever do, who knows what kind of DT data they need. I know the
> >> DT data for SGX in TI's kernel tree has changed at least once.
> >
> > I don't think reg or interrupts will be removed, so the properties
> > added by Tony look pretty safe?. I guess if we ever have a driver
>
> Maybe. At the moment we have this in TI's tree for DRA7:
>
> gpu: gpu@56000000 {
> compatible = "ti,dra7-sgx544", "img,sgx544";
> reg = <0x56000000 0x10000>;
> reg-names = "gpu_ocp_base";
> interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> ti,hwmods = "gpu";
> clocks = <&l3_iclk_div>, <&gpu_core_gclk_mux>,
> <&gpu_hyd_gclk_mux>;
> clock-names = "iclk", "fclk1", "fclk2";
> };
>
> > it would need some more properties and would bail out. Having no
> > DT data is does not load at all, the result is the same. OTOH having
> > the node means the kernel can properly send the module to idle.
>
> I just get uneasy when adding DT data that we're not really sure if it's
> ok or not. I've been fighting with such data for ages. But, as you say,
> this probably won't matter if the driver will just reject DT data that
> doesn't have all the details.
The above example looks OK to me, the interrupt is different for omap4.
> If we need the DT node to idle SGX, and we don't even mean to actually
> use an SGX driver with this data, it sounds fine to me.
Well ideally the SGX driver will make use of it too. Let me know
if you want to leave out some parts of the above example from
TI tree.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
