Hi Hayashi-san,
2017-07-05 20:53 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>:
> Add nodes of thermal monitor and thermal zone for UniPhier LD20 SoC.
> The thermal monitor is included in sysctrl.
>
> Furthermore, since the reference board doesn't have a calibrated value of
> thermal monitor, this patch gives the default value for LD20 reference
> board.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> ---
> .../arm64/boot/dts/socionext/uniphier-ld20-ref.dts | 4 +++
> arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 40 ++++++++++++++++++++++
> 2 files changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
> index 609162a..d7f6b39 100644
> --- a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
> +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
> @@ -86,3 +86,7 @@
> &i2c0 {
> status = "okay";
> };
> +
> +&pvtctl {
> + socionext,tmod-calibration = <0x0f22 0x68ee>;
> +};
I think this calib value is shared among all boards
(ref and global).
Please move it to the SoC dtsi.
> + cooling-maps {
> + map0 {
> + trip = <&cpu_alert>;
> + cooling-device = <&cpu0 (-1) (-1)>;
> + };
> + map1 {
> + trip = <&cpu_alert>;
> + cooling-device = <&cpu2 (-1) (-1)>;
> + };
> + };
> + };
> + };
> +
After all, I decided to use dt-bindings headers.
Could you use THERMAL_NO_LIMIT for clarification?
--
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
