On Wed, Aug 9, 2017 at 10:57 AM, Ray Jui <ray.jui@xxxxxxxxxxxx> wrote: > > > On 8/8/2017 10:22 PM, Oza Oza wrote: >> >> On Tue, Aug 8, 2017 at 7:50 PM, Rob Herring <robh+dt@xxxxxxxxxx> wrote: >>> >>> Please send bindings to DT list. >> >> Sure, will do that. >> >>> On Mon, Aug 7, 2017 at 11:44 PM, Oza Pawandeep <oza.oza@xxxxxxxxxxxx> >>> wrote: >>>> >>>> Add description for optional device tree property >>>> 'brcm,pci-hotplug' for PCI hotplug feature. >>>> >>>> Signed-off-by: Oza Pawandeep <oza.oza@xxxxxxxxxxxx> >>>> Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx> >>>> >>>> diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt >>>> b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt >>>> index b8e48b4..a3bad24 100644 >>>> --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt >>>> +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt >>>> @@ -72,6 +72,29 @@ Optional properties: >>>> - brcm,pcie-msi-inten: Needs to be present for some older iProc >>>> platforms that >>>> require the interrupt enable registers to be set explicitly to enable >>>> MSI >>>> >>>> +Optional properties: >>>> +- brcm,pci-hotplug: PCI hotplug feature is supported. >>> >>> I think we should make this a common property. We already have >>> "ibm,slot-pluggable", so I'd propose "slot-pluggable". >>> >>> There's also "hotpluggable" for memory nodes defined, so we could >>> reuse that here. >>> >> ok I will rename this to >> brcm,slot-pluggable > > > How's brcm,slot-pluggable a common property? It's still brcm specific. > Didn't Rob propose either "slot-pluggable" or "hotpluggable"? > > And note it goes to the generic PCI binding instead iProc PCIe specific > binding. > Initially I thought, Rob suggested either "slot-pluggable". followed by, "hotpluggable" since memory node already has such property. but not sure in which generic pci binding I should add ? should it be part of Documentation/devicetree/bindings/pci/host-generic-pci.txt Can you please clarify Rob ? Regards, Oza. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
