Hi Florian & ChenYu
在 2017/8/3 1:38, Florian Fainelli 写道:
This is incorrect in two ways:
- this is a property of the PHY, so it should be documented as such in
Documentation/devicetree/bindings/net/phy.txt so other bindings can
re-use it
- if it was specific to your MAC you would expect a vendor prefix to
this property, which is not there
An alternative way to implement the external/internal logic selection
would be mandate that your Ethernet PHY node have a compatible string
like this:
phy@0 {
compatible = "ethernet-phy-id1234.d400", "ethernet-phy-802.3-c22";
};
Then you don't need this phy-is-internal property, because you can
locate the PHY node by the phy-handle (see more about that in a reply to
patch 10) and you can determine ahead of time whether this PHY is
internal or not based on its compatible string.
We may implement a read_bool_property after parsed phy phandle at
stmmac_platform.c, which would make MAC driver know it is a internal phy.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
