On Wed, Aug 2, 2017 at 4:30 PM, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > On 08/02/2017 03:18 PM, Oleksandr Shamray wrote: >> Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller. >> +static u32 aspeed_jtag_read(struct aspeed_jtag *aspeed_jtag, u32 reg) >> +{ >> + return readl(aspeed_jtag->reg_base + reg); >> +} >> + >> +static void >> +aspeed_jtag_write(struct aspeed_jtag *aspeed_jtag, u32 val, u32 reg) >> +{ >> + writel(val, aspeed_jtag->reg_base + reg); >> +} > > Maybe readl_relaxed/writel_relaxed would be enough here. I'd prefer keeping the regular accessors here, unless this is shown to be a performance bottleneck, and there is a comment to explain how the relaxed accessors are determined to be safe. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html