> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@xxxxxxxx] > Sent: Thursday, January 16, 2014 7:03 PM > To: Lu Jingchang-B35083 > Cc: vinod.koul@xxxxxxxxx; dan.j.williams@xxxxxxxxx; shawn.guo@xxxxxxxxxx; > pawel.moll@xxxxxxx; mark.rutland@xxxxxxx; swarren@xxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; Wang Huan-B18965 > Subject: Re: [PATCHv9 2/2] dma: Add Freescale eDMA engine driver support > > On Thursday 16 January 2014, Jingchang Lu wrote: > > Add Freescale enhanced direct memory(eDMA) controller support. > > This module can be found on Vybrid and LS-1 SoCs. > > > > Signed-off-by: Alison Wang <b18965@xxxxxxxxxxxxx> > > Signed-off-by: Jingchang Lu <b35083@xxxxxxxxxxxxx> > > Very nice! All my previous comments have been addressed, so > > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> > > One small comment still: > > > + > > +static DEFINE_MUTEX(fsl_edma_mutex); > > + > > I think this mutex should be part of struct fsl_edma_engine, not global. Yes, it should be for each edma controller, I will define it in struct fsl_edma_engine. Thanks. Best Regards, Jingchang ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
