On Thursday 16 January 2014, Jingchang Lu wrote: > Add Freescale enhanced direct memory(eDMA) controller support. > This module can be found on Vybrid and LS-1 SoCs. > > Signed-off-by: Alison Wang <b18965@xxxxxxxxxxxxx> > Signed-off-by: Jingchang Lu <b35083@xxxxxxxxxxxxx> Very nice! All my previous comments have been addressed, so Acked-by: Arnd Bergmann <arnd@xxxxxxxx> One small comment still: > + > +static DEFINE_MUTEX(fsl_edma_mutex); > + I think this mutex should be part of struct fsl_edma_engine, not global. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html