On Mon, 17 Jul 2017, Moritz Fischer wrote: > Hi Lee, > > On Mon, Jul 17, 2017 at 08:51:17AM +0100, Lee Jones wrote: > > On Thu, 13 Jul 2017, Moritz Fischer wrote: > > > > > From: Moritz Fischer <moritz.fischer@xxxxxxxxx> > > > > > > Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. > > > The device can either be configured as simple RTC, as simple RTC with > > > Alarm (IRQ) as well as simple RTC with watchdog timer. > > > > > > Break up the old monolithic driver in drivers/rtc/rtc-ds1374.c into: > > > - rtc part in drivers/rtc/rtc-ds1374.c > > > - watchdog part under drivers/watchdog/ds1374-wdt.c > > > - mfd part drivers/mfd/ds1374.c > > > > > > The MFD part takes care of trickle charging and mode selection, > > > since the usage modes of a) RTC + Alarm or b) RTC + WDT > > > are mutually exclusive. > > > > > > Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx> > > > --- > > > drivers/mfd/Kconfig | 10 + > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/ds1374.c | 260 ++++++++++++++++ > > > drivers/rtc/rtc-ds1374.c | 639 ++++++++++----------------------------- > > > > It looks like this should now depend on MFD_DS1374, right? > > > > > drivers/watchdog/Kconfig | 10 + > > > drivers/watchdog/Makefile | 1 + > > > drivers/watchdog/ds1374-wdt.c | 208 +++++++++++++ > > > > The RTC and Watchdog drivers need to be split out of this patch and > > placed into their own. Then we can take them through their respective > > subsystem trees and do not have to rely on immutable branches for > > unification. > > Ok, I haven't found a good way to keep this bisectable in that case. I'm > open to suggestions. If the consensus ends up being to split it up, I'm > more than happy to separate it out into multiple patches. If it's genuinely not bisectable, then leave it as is. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
