> -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: Saturday, July 15, 2017 4:34 AM > To: Mykola Kostenok <c_mykolak@xxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx; Guenter Roeck <linux@xxxxxxxxxxxx>; > Jaghathiswari Rankappagounder Natarajan <jaghu@xxxxxxxxxx>; > openbmc@xxxxxxxxxxxxxxxx; Patrick Venture <venture@xxxxxxxxxx>; Vadim > Pasternak <vadimp@xxxxxxxxxxxx>; Ohad Oz <ohado@xxxxxxxxxxxx> > Subject: Re: [patch v1] Documentation: dt-bindings: aspeed-pwm-tacho > cooling device. > > On Tue, Jul 11, 2017 at 04:18:27PM +0300, Mykola Kostenok wrote: > > This binding adds description for interface supporting > > aspeed-pwm-tacho driver cooling device creation. > > This cooling device could be bound to a thermal zone for the thermal > > control. > > Bindings are for devices, not drivers. > > > > It adds extra level of hierarchy - for tachometer channel with fan > > subnodes and pwm channels with pwm subnodes. > > Why this binding was just added and now it is changing? > Hi, Rob. Thanks for reply. This controller supports fan tacho channels and pwm channels. In the previous dts version, only tachometers channels were configurable. We need to set pwm channels as cooling device, since we use it for the thermal control. So, these channels are added to dts as well. And it added extra level hierarchy in dts. For now this driver is used only by 2 two platforms: our Mellanox and Quanta (openbmc project). We sent first this patch to openbmc first the for approval from the Quanta owners (Patrick Venture <venture@xxxxxxxxxx> approved this change). The support of this change in dts is introduce in the patch for drivers/hwmon/aspeed-pwm-tacho.c, which has been sent to hwmon maintainers. Best regards. Mykola Kostenok. > > > > Signed-off-by: Mykola Kostenok <c_mykolak@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 56 > > ++++++++++++++++++---- > > 1 file changed, 47 insertions(+), 9 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
